Conversation
Closes stepfun-ai#85 Idle inbox waits and claim-slot backoff ignored cancellation, so Ctrl+C during delegation/handoff delays blocked until delayMs elapsed. Match agent-loop abort cleanup and wire the team abort signal into those call sites.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-teamidle waits ignored cancel: Ctrl+C during delegation/handoff delays had to wait outdelayMs.agent-loopsleep already honored AbortSignal; team waits did not.This wires a real abort path into the team sleep call sites (not a dead optional param). Aligns with ZouR-Ma's guidance on #98 (which withdrew a partial #85 attempt).
Closes #85
Changes
agent-loopsleep: abort rejects promptly; remove abort listener on abort and on normal timer completion.AgentTeam.close()aborts a team-level signal so idle waits wake immediately.readInboxidle polling and worker claim-slot backoff.read_inboxforwards the tool AbortSignal intoreadInbox.Tests
readInboxwait; already-aborted signal; normal completion cleans listenerclose()wakes idle worker waits and claim-slot backoffctx.signalintoreadInboxpnpm check: 1529 passed, 8 skipped