Clean up min block scripts - #429
Open
drebelsky wants to merge 1 commit into
Open
Conversation
Make slp_eval and measure_e2e both easier to use wrappers around one common script.
drebelsky
force-pushed
the
clean-up-min-block-scripts
branch
from
August 19, 2026 19:09
e01bda0 to
f051651
Compare
drebelsky
marked this pull request as ready for review
August 19, 2026 22:33
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors MinBlockTimeMixed benchmark wrappers around a shared implementation.
Changes:
- Adds shared parsing, validation, execution, and failure aggregation.
- Restores the streamlined
slp_evalinterface. - Expands
measure_e2ewith scaling and latency controls.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
scripts/base.sh |
Adds shared benchmark implementation. |
scripts/slp_eval.sh |
Uses shared fixed evaluation configuration. |
scripts/measure_e2e.sh |
Adds configurable end-to-end latency benchmarking. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+243
to
+245
| if ! is_nonnegative_integer "$BLOCK_TIME_MS" || [ "$BLOCK_TIME_MS" -le "$BLOCK_TIME_BAND_MS" ]; then | ||
| fail "Block time must be an integer greater than ${BLOCK_TIME_BAND_MS}ms." | ||
| fi |
| return 1 | ||
| fi | ||
|
|
||
| existing=$((key_count / TIER1_ORG_SIZE)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make slp_eval and measure_e2e both easier to use wrappers around one common script.
slp_eval's interface is mostly restored to how it was pre 8351664.measure_e2e's interface is changed to make it easier to test against our scaling goals. Additionally, the following changes are made--ingress-external-hostis now a documented parameter for both scripts--enable-relaxed-auto-qset-configis added to the command line since Use automatic quorum set configuration by default #396 has still not mergedsac/oz/soroswap, the return value is 0 only iff all returned 0