Skip to content

add socket tier 1 reachability analysis - #402

Open
kanwalpreetd wants to merge 4 commits into
stellar:mainfrom
kanwalpreetd:main
Open

add socket tier 1 reachability analysis#402
kanwalpreetd wants to merge 4 commits into
stellar:mainfrom
kanwalpreetd:main

Conversation

@kanwalpreetd

Copy link
Copy Markdown

Copilot AI review requested due to automatic review settings June 30, 2026 06:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a scheduled/on-demand GitHub Actions workflow to run Socket “full application reachability” scanning for this repo, with a log-based warning when the scan falls back from Tier 1 to Tier 2 reachability.

Changes:

  • Introduces a new socket-scan workflow triggered weekly and via workflow_dispatch.
  • Installs required toolchains (Dotnet + Node) and the Socket CLI, then runs socket scan create --reach.
  • Parses scan output to emit a GitHub Actions ::warning:: when Tier 2 fallbacks are detected while still keeping a successful (exit 0) run.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/socket-scan.yml Outdated
Comment thread .github/workflows/socket-scan.yml Outdated
Comment on lines +77 to +78
- name: Install Socket CLI
run: npm install -g socket

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left as unpinned to include latest features/support in the CLI without needing to bump it periodically, I think pinning will add too much overhead for maintenance, probably not worth it for this kind of generic tool. (the socket API token used by the job has limited permissions to only trigger a new scan in Socket backend, so the risk of a new malicious CLI release is contained)

Comment thread .github/workflows/socket-scan.yml
Comment thread .github/workflows/socket-scan.yml
kanwalpreetd and others added 3 commits August 20, 2026 15:53
- Make the Node 24 env-var comment date-agnostic (2026-06-16 has passed)
- Remove the unused Corepack step; this repo has no package.json, so it
  only ever shimmed yarn/pnpm that are never invoked

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
It is now dead config, for two independent reasons:

- Every action pinned in this workflow already declares `using: node24`
  in its action.yml, and the var only upgrades actions that declare
  node20 — so it had no effect here even before the cutover.
- GitHub runners have defaulted to Node 24 since 2026-06-16, and Node 20
  is fully removed on 2026-09-16.

Note the var never silenced the node20 deprecation warnings either: the
runner classifies an action from its declared version before consulting
this var (actions/runner#4295).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants