Exclude SCV_EXECUTABLE_TAG from the spec check - #315
Merged
Conversation
leighmcculloch
marked this pull request as ready for review
August 13, 2026 23:23
leighmcculloch
enabled auto-merge (squash)
August 13, 2026 23:24
leighmcculloch
disabled auto-merge
August 13, 2026 23:24
leighmcculloch
enabled auto-merge (squash)
August 13, 2026 23:24
Contributor
There was a problem hiding this comment.
Pull request overview
Excludes SCV_EXECUTABLE_TAG from the SCSpecType superset check because SDKs expose it as a string rather than a distinct specification type.
Changes:
- Adds
EXECUTABLE_TAGto the exclusion list. - Documents why this boundary-capable value intentionally lacks an SCSpecType counterpart.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dmkozh
reviewed
Aug 14, 2026
dmkozh
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
EXECUTABLE_TAGto the excluded variants in.scripts/check-scspectype-superset.ts, with a comment recording why it is excluded despite being passable across a contract function boundary.Why
The check has failed on
mainsince it merged in #314, becauseSCV_EXECUTABLE_TAGfrom CAP-85 has noSC_SPEC_TYPE_EXECUTABLE_TAG— the SDK deliberately exposes the executable tag everywhere as a String for a better and more consistent UX, treatingSCV_EXECUTABLE_TAGas a storage implementation detail, so no spec type is planned.