starknet_transaction_prover: global panic hook + graceful SIGTERM shutdown#14166
starknet_transaction_prover: global panic hook + graceful SIGTERM shutdown#14166avi-starkware wants to merge 2 commits into
Conversation
PR SummaryLow Risk Overview A process-wide panic hook ( SIGTERM/SIGINT are bridged via Reviewed by Cursor Bugbot for commit cffb6a6. Bugbot is set up for automated code reviews on this repo. Configure here. |
63d34df to
c31ce65
Compare
c31ce65 to
72a08b0
Compare
2dcb716 to
f83f30c
Compare
72a08b0 to
17dbfd9
Compare
f83f30c to
53b6a1e
Compare
17dbfd9 to
9845d29
Compare
9845d29 to
4d23115
Compare
53b6a1e to
4645e9b
Compare
4d23115 to
c3950e4
Compare
4645e9b to
278ffaa
Compare
c3950e4 to
fe2dccc
Compare
6a64324 to
e28dee6
Compare
91c2bfc to
b232a8e
Compare
d99ffe1 to
264bf5b
Compare
b232a8e to
fb6037b
Compare
264bf5b to
282284b
Compare
fb6037b to
4055121
Compare
282284b to
073a1ff
Compare
4055121 to
bfa94e0
Compare
8d4c874 to
bdf34cf
Compare
54145f3 to
adf3407
Compare
bdf34cf to
15340a8
Compare
15340a8 to
d7e132f
Compare
adf3407 to
a6853d8
Compare
a6853d8 to
ad1b9cc
Compare
d7e132f to
2c600ed
Compare
ad1b9cc to
589df8a
Compare
2c600ed to
0abb13e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0abb13e. Configure here.
…tdown Installs a process-wide panic hook that emits one structured `event=panic` tracing event with location and backtrace, and bridges SIGTERM/SIGINT into `ServerHandle::stop` so container teardown becomes visible in logs and in-flight proofs get to finish. A second signal forces `exit(1)` to work around tokio-rs/tokio#7905. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Force-exit on a second termination signal now only applies while the drain is still in progress; once the server has stopped cleanly a late signal no longer flips the exit code to 1. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
0abb13e to
cffb6a6
Compare
589df8a to
79191bf
Compare


Installs a process-wide panic hook that emits one structured
event=panictracing event with location and backtrace, and bridges SIGTERM/SIGINT into
ServerHandle::stop(extracted toserver/shutdown.rs, keepingmain.rstoa single call) so container teardown becomes visible in logs and in-flight
proofs get to finish. A second signal while the drain is still in progress
forces
exit(1)so an operator can always reclaim a stuck process(tokio-rs/tokio#7905); once the server has stopped cleanly, a late signal no
longer flips the exit code.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com