Skip to content

Omri/temp branch#380

Closed
OmriEshhar1 wants to merge 2 commits into
mainfrom
omri/temp-branch
Closed

Omri/temp branch#380
OmriEshhar1 wants to merge 2 commits into
mainfrom
omri/temp-branch

Conversation

@OmriEshhar1

@OmriEshhar1 OmriEshhar1 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

This change is Reviewable

@cursor

cursor Bot commented Jul 2, 2026

Copy link
Copy Markdown

PR Summary

High Risk
Prover/verification behavior can change with the stwo-cairo pin, and the workflow edits (no main, pinned SHA) are unsafe to merge as-is for production artifact publishing.

Overview
Bumps all workspace stwo-cairo git dependencies from a837f0e… to 9b93cc39, with Cargo.lock updated so local crates (stwo-run-and-prove, vm_runner, etc.) resolve the new rev. Transitive stwo-circuits crates still pull cairo-air / stwo-cairo-common at a837f0e…, so the lockfile now lists duplicate versions of those packages.

Upload-Artifacts is retargeted: pushes on main are removed, the workflow runs only on omri/temp-branch, and COMMIT_SHA is hardcoded to a fixed hash instead of github.sha for the short-hash artifact paths—typical of a one-off build/publish test.

Reviewed by Cursor Bugbot for commit 7ff4ce5. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7ff4ce5. Configure here.

- name: Get commit hash prefix for PR update
env:
COMMIT_SHA: ${{ github.sha }}
COMMIT_SHA: c82f9170592ad918c84ec206be99aa895578f5a5

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded commit hash in workflow

High Severity

COMMIT_SHA is set to a fixed git hash instead of ${{ github.sha }}, so every run publishes under the same SHORT_HASH prefix regardless of the checked-out commit. Artifact paths no longer match the build source and can overwrite prior uploads.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 7ff4ce5. Configure here.

@OmriEshhar1 OmriEshhar1 closed this Jul 2, 2026
@OmriEshhar1 OmriEshhar1 deleted the omri/temp-branch branch July 2, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants