Skip to content

Omri/temp branch#379

Closed
OmriEshhar1 wants to merge 2 commits into
mainfrom
omri/temp-branch
Closed

Omri/temp branch#379
OmriEshhar1 wants to merge 2 commits into
mainfrom
omri/temp-branch

Conversation

@OmriEshhar1

@OmriEshhar1 OmriEshhar1 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

This change is Reviewable

@cursor

cursor Bot commented Jul 2, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changing the stwo-cairo revision affects the proving/verification stack, and the lockfile temporarily mixes two stwo-cairo SHAs via stwo-circuits, which can cause subtle build or runtime mismatches until dependencies are aligned.

Overview
Pins all workspace stwo-cairo git dependencies from a837f0e to 9b93cc39 in Cargo.toml, with a matching Cargo.lock refresh. The lockfile now carries two stwo-cairo revisions: workspace crates (stwo-run-and-prove, privacy-prove, etc.) resolve to 9b93cc39, while stwo-circuits-pulled crates still depend on cairo-air / stwo-cairo-* at a837f0e.

The Upload-Artifacts workflow is extended so pushes to omri/temp-branch also run the release build and GCS upload pipeline (same as main).

Reviewed by Cursor Bugbot for commit 53a5647. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 53a5647. Configure here.

Comment thread Cargo.toml
stwo-cairo-adapter = { git = "https://github.com/starkware-libs/stwo-cairo", rev = "9b93cc39" }
stwo-cairo-prover = { git = "https://github.com/starkware-libs/stwo-cairo", rev = "9b93cc39" }
stwo-cairo-serialize = { git = "https://github.com/starkware-libs/stwo-cairo", rev = "9b93cc39" }
stwo-cairo-common = { git = "https://github.com/starkware-libs/stwo-cairo", rev = "9b93cc39" }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split stwo-cairo git revisions

Medium Severity

Workspace stwo-cairo pins move to 9b93cc39, but privacy-prove and privacy-circuit-verify still depend on a837f0e, so stwo-run-and-prove artifacts and the privacy proving stack no longer share the same Cairo/STWO revision.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 53a5647. Configure here.

@OmriEshhar1 OmriEshhar1 closed this Jul 2, 2026
@OmriEshhar1 OmriEshhar1 deleted the omri/temp-branch branch July 2, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants