Open
Conversation
This was referenced Mar 12, 2026
11 tasks
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Member
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Left a couple of comments about namespace deletion.
Techassi
reviewed
Mar 25, 2026
Member
Techassi
left a comment
Techassi
left a comment
There was a problem hiding this comment.
Left a few comments and questions.
This reverts commit 7dfe50e.
Co-authored-by: Techassi <git@techassi.dev>
Techassi
reviewed
Mar 27, 2026
Member
Techassi
left a comment
Techassi
left a comment
There was a problem hiding this comment.
Only a few small comments left, mostly looks nice!
| }; | ||
|
|
||
| for object in object_list { | ||
| if let Some(value) = object.labels().get(&label.key().to_string()) { |
Member
There was a problem hiding this comment.
note: This is kinda cumbersome to use, but could be improved by stackabletech/operator-rs#1182 (if we decide to move forward with it).
Member
There was a problem hiding this comment.
The linked PR was merged btw, but not yet released.
Techassi
previously approved these changes
Apr 7, 2026
NickLarsenNZ
reviewed
Apr 8, 2026
Comment on lines
+517
to
+530
| let proceed_with_uninstall = tracing_indicatif::suspend_tracing_indicatif( | ||
| || -> Result<bool, CmdError> { | ||
| Confirm::new() | ||
| .with_prompt( | ||
| format!( | ||
| "Uninstalling the demo {demo_name:?} will delete the {demo_namespace:?} namespace. This action cannot be undone. Proceed?", | ||
| demo_name = args.demo_name.clone(), | ||
| demo_namespace = args.namespaces.namespace.clone()) | ||
| ) | ||
| .default(true) | ||
| .interact() | ||
| .context(ConfirmDialogSnafu) | ||
| }, | ||
| )?; |
Member
There was a problem hiding this comment.
Curious what happens when this runs in a script? Does indicative choose something, or just hang?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #187
This PR adds the
uninstallsubcommands todemoandstackcommands. It implements the MVP features mentioned here #187 (comment)The flag of skipping operators and CRD deletion was optional and I wasn't sure about the naming or if needs to be one command or two. Can also be just removed, added it because it was not much additional work.
Tested with all current demos/stacks. Some demos have edge cases in the deletion, will document that in the parent issue.
This PR also contains thestripped out into #432DEMO/STACKparameter addition for stackabletech/demos#374 (comment)Definition of Done Checklist
Author
Reviewer
Acceptance