Skip to content

update to api 2 - #80

Open
inlineHamed wants to merge 1 commit into
ssone95:masterfrom
inlineHamed:master
Open

inlineHamed wants to merge 1 commit into
ssone95:masterfrom
inlineHamed:master

Conversation

@inlineHamed

@inlineHamed inlineHamed commented May 6, 2025 •

Copy link
Copy Markdown

I've updated ChromaClient and ChromaCollectionClient, with most of the work done by DeepSeek. I believe there's an error in the Chroma Swagger documentation regarding working with collections in API v2 2 api: chroma-core/chroma#4456
For now, I have implemented these two changes in a way that they work.
79 tests passed, but some failed—I have no idea why, and I don't have more time to investigate:
image

remove deleted data field from CollectionEntriesGetResponse and CollectionEntriesQueryResponse
@sis707

sis707 commented May 28, 2025

Copy link
Copy Markdown

Hi, first thank you for the good job :-). I only miss the uris property when adding records...

@ssone95

ssone95 commented Aug 5, 2025

Copy link
Copy Markdown
Owner

I've updated ChromaClient and ChromaCollectionClient, with most of the work done by DeepSeek. I believe there's an error in the Chroma Swagger documentation regarding working with collections in API v2 2 api: chroma-core/chroma#4456 For now, I have implemented these two changes in a way that they work. 79 tests passed, but some failed—I have no idea why, and I don't have more time to investigate: image

Hi @inlineHamed,
first of all - thank you for the effort!

After spending a bit of time away from the project I'll be checking the pull request you posted. Regarding Unit Tests - these are mandatory, but I'll get myself familiar with the changes you made while focusing on the APIs available in the Chroma V2, to see if there are any missing functionalities or features which changed significantly until this moment.

@inlineHamed

Copy link
Copy Markdown
Author

@ssone95 you're welcome
Almost all of the commit is about changing chroma api urls structure

@ssone95

ssone95 commented Aug 6, 2025 •

Copy link
Copy Markdown
Owner

@ssone95 you're welcome Almost all of the commit is about changing chroma api urls structure

Yes, and it makes sense - but that's something I plan to discuss with @cincuranet as we'll need to work on (potentially full) Chroma V2 support, and that involves other features it brings us, so we may need to change the way some of these work. At the moment - this patch looks good, but we can't merge it yet until we get to decide how we'll handle other things related to V2.

@Laurianti

Laurianti commented Oct 3, 2026 •

Copy link
Copy Markdown

Thank you. This is in #84, with its original commit and your authorship. The record URIs asked above are there too. On the other points above: in #84 the whole suite runs in the CI against ten Chroma versions, the client covers the v2 API except search, and get and delete use the name of the collection, as chroma-core/chroma#4456 notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants