Skip to content

Fix positional argument passing to JLINKARM_BeginDownload - #270

Merged
hkpeprah merged 1 commit into
square:masterfrom
NickeZ:begindownload-arg
Sep 14, 2026
Merged

hkpeprah merged 1 commit into
square:masterfrom
NickeZ:begindownload-arg

Conversation

@NickeZ

@NickeZ NickeZ commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

ctypes ignores the flags keyword argument, leaving the native function without its argument. Pass flags positionally so it receives zero.

fixes #269

ctypes ignores the flags keyword argument, leaving the native function
without its argument. Pass flags positionally so it receives zero.
@CLAassistant

CLAassistant commented Sep 9, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@hkpeprah

hkpeprah commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

LGTM. I'll kick off CI. The CLA will have to be signed for us to accept changes though 🙏

@NickeZ

NickeZ commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

LGTM. I'll kick off CI. The CLA will have to be signed for us to accept changes though 🙏

done

@hkpeprah

Copy link
Copy Markdown
Contributor

Thanks for the fix, will include it in a patch release 👍

@hkpeprah
hkpeprah merged commit 08a9b94 into square:master Sep 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wrong args to c function JLINKARM_BeginDownload

4 participants