Repository navigation
Pass CancelSignal to in-process HeapAnalyzerWorker - #3021
Open
mayokunyusuf wants to merge 1 commit into
Open
mayokunyusuf wants to merge 1 commit into
mayokunyusuf wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When JobScheduler stops an expedited job running
HeapAnalyzerWorker(e.g. on Android 12–16 after timeout or doze), WorkManager reschedules the work while the currentdoWork()continues running. BecauseHeapAnalyzerWorkerwas not checkingisStoppedor passing aCancelSignal, multiple full heap analyses could run concurrently in the same process, often ending in OutOfMemory.This mirrors the pattern already used in
RemoteHeapAnalyzerWorker:CancelSignaltorunAnalysisBlockingcheckingisStoppedCanceledException, log the cancellation, and returnResult.retry()HeapAnalysisDoneor progress events when stoppedCloses #3019.