Make JFR-based observability opt-in - #5524
Open
fabiomolignoni wants to merge 1 commit into
Open
fabiomolignoni wants to merge 1 commit into
fabiomolignoni wants to merge 1 commit into
Conversation
Signed-off-by: Fabio Molignoni <fabiomolignoni@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5326.
Spring Batch currently instantiates JFR events directly, causing NoClassDefFoundError when running on minimized Java runtimes without the jdk.jfr module.
This change introduces a JFR-independent BatchEventRecorder abstraction with a no-op default implementation. FlightRecorderBatchEventRecorder provides explicit JFR activation, with recorder configuration supported through the application context, builders, and setters.
This follows the same opt-in approach as Spring Framework's ApplicationStartup infrastructure, which uses a no-op implementation by default and provides FlightRecorderApplicationStartup for explicitly enabling JFR startup events.
Existing batch event instrumentation delegates to the new abstraction, and the documentation explains how to enable JFR recording.
Validation: