Fix StringIndexOutOfBoundsException for a lone quote field in DelimitedLineTokenizer - #5522
Open
harrisleesh wants to merge 1 commit into
Open
harrisleesh wants to merge 1 commit into
harrisleesh wants to merge 1 commit into
Conversation
…edLineTokenizer The quote-wrapping guard checked the length of the whole line instead of the token, so a one-character token consisting of the quote character itself matched both quote checks with the same character and produced a negative substring range. Check the token length instead, returning a lone quote field literally, consistent with how a lone quote line is already handled. Fixes spring-projects#5519 Signed-off-by: seonghun lee <harrisleesh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5519
The quote-wrapping guard in
substringWithTrimmedWhitespaceAndQuotesIfQuotesPresentchecked the length of the whole line instead of the token, so a one-character token consisting of the quote character itself (e.g. the last field ofa,") matched both quote checks with the same character and produced a negative substring range.This change checks the token length instead, returning a lone quote field literally — consistent with how a lone quote line (
tokenize("\"")) is already handled.Two regression tests added; the field-level one fails on
mainwithStringIndexOutOfBoundsExceptionand passes with the fix.DelimitedLineTokenizerTestspasses 44/44.