You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Revise update-learn-page action to not do condition if the token provided or not #102
If we are aiming to make our release solution reusable for both OSS and commercial versions, then we should not do condition if token provided or not. It really has to be provided transparently in both environment.
Instead I suggest to provide a boolean flag to call project website API or Git commits directly.
Or even better: always call API and fallback to Git if there is no such an API.
I guess there is no for commercial, but that is what we can calculate by the repository we are in.
The token is always required and we always call project API for OSS, just because there is additional functionality behind the scene which would be by passed if we can Git directly.
FYI, we have agreed with @mbhave that spring-builds got a push permission on the commercial website content repository.
Therefore, there is no need to manage on our side extra GH token.
And from here it would be great that there would be no any conditional logic in the action regarding token presence - and it would just go to API service layer or fallback to Git if no such an API.
Probably some internal state could be determined according to the repo we are in.
Activity
artembilan commentedon Apr 7, 2026
FYI, we have agreed with @mbhave that
spring-buildsgot a push permission on the commercial website content repository.Therefore, there is no need to manage on our side extra GH token.
And from here it would be great that there would be no any conditional logic in the action regarding token presence - and it would just go to API service layer or fallback to Git if no such an API.
Probably some internal state could be determined according to the repo we are in.
Thanks