merge upstream - #17
Draft
spinute wants to merge 260 commits into
Draft
Conversation
This reverts commit fcd052e.
Now that we have a go.mod, we can properly upgrade to blackfriday/v2 The output remains the same, but this PR brings back italic links with '_', placing them into the link since this seems to be the more proper way. Fixes #182
Use Chroma for syntax highlighting and remove vendor'd Pygments
* Add myself to footer * Add myself to the example template as well, and rebuild
This is in line with the Go support policy of current version + previous version
* Remove use of deprecated ioutil functions from examples * Remove usage of ioutil from gobyexample's own scripts + regenerate output
* Clarify comment for the goroutines sample. The current comment may be interpreted to say that the output must be interleaved, when in fact it doesn't have to be (it depends on the order the goroutines are run). Make the comment more permissive to avoid the confusion. Fixes #365 * Fix phrasing in comment
gobyexample doesn't use pygments anymore, so the generate program doesn't spawn anything.
It works using a test bucket
The script sets up the -region and -bucket flags to point to the right S3 location. AWS_* env vars should still be set manually. The old Ruby uploading code is moved to upload-ruby-old for now (will be deleted later)
More than one example in it now
Also rebuild output
The new Go-based code works fine and has successfully uploaded the site several times now. This removes a dependency on a non-Go flow which should make development easier.
The link appears to be dead
* Update stateful-goroutines.go Replace the digit '1' with the word one for 'one goroutine' * Update stateful-goroutines Change stateful-goroutines under public/ to reflect real changes * Update Go Playground link Update go playground link with proper example
Now that we have wider lines in measure.go
Bumps [github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream](https://github.com/aws/aws-sdk-go-v2) from 1.4.14 to 1.7.8. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@internal/v4a/v1.4.14...service/m2/v1.7.8) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream dependency-version: 1.7.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Bumps [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2) from 1.40.2 to 1.97.3. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.40.2...service/s3/v1.97.3) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/s3 dependency-version: 1.97.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: check unmanaged errors Add checking to the errors returned by json.Unmarshal(), *Encoder.Encode(), *Decoder.Decode(). Leave the ignored(_) errors as is, I suppose they are being managed. * fix: ignore errors, add clarification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.