Repository navigation
Conversation
The method returns (string, bool) from os.LookupEnv and applies the AllowEmptyEnv rule, which os.Getenv cannot express.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Fix the
getEnvdoc comment: the method wrapsos.LookupEnv, notos.Getenv, and additionally applies theAllowEmptyEnvrule.What problem does it solve?:
The comment above
getEnvsays "a wrapper around os.Getenv", but the method returns(string, bool)obtained fromos.LookupEnv(viper.go:421) and post-processes the result withok && (v.allowEmptyEnv || val != "")(viper.go:423).os.Getenvcannot express either the presence check or the empty-value semantics, so the comment names the wrong function and hides the documentedAllowEmptyEnvbehavior.Special notes for a reviewer:
Comment-only change, no behavior touched.