Repository navigation
fix: no undefined index in "output should (not) be:" - #49
Merged
Jean-Beru merged 2 commits intoOct 17, 2026
Merged
Conversation
The "command should succeed" and "command should fail" steps formatted the return code with "%b", in binary. For an exit code of 2, the message was "Command should succeed 10". Use "%d", so that the message is "Command should succeed 2". Assisted-by: Claude:claude-opus-5-5
The "output should be:" and "output should not be:" steps read an undefined index of the expected lines when the output had more lines. PHP then emitted an "Undefined array key" warning. A missing expected line is now null, so it differs from the output line. The step results and the exception messages do not change. Assisted-by: Claude:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #48: review only the last commit.
When the command output has more lines than the expected text,
output should be:andoutput should not be:read an undefined index and PHP emits anUndefined array keywarning. A missing expected line is nownull: the step result and the messages do not change, only the warning goes away.Before: fails with an
Undefined array key 1warning. After: fails withinstead offollowed by the real output.