This repository was archived by the owner on Aug 1, 2025. It is now read-only.
fix: release canvas after use - #8123
Draft
fengzhou-sg wants to merge 1 commit into
Draft
fengzhou-sg wants to merge 1 commit into
fengzhou-sg wants to merge 1 commit into
Conversation
Call `canvas.dispose` to clean-up resources after uses. This should prevent memory leak, which may cause failures in new canvas creations. ref: CODY-6011
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call
canvas.disposeto clean-up resources after uses. This should prevent memory leak, which may cause failures in new canvas creations.See also Shopify/react-native-skia#2079
ref: CODY-6011
Test plan