[process-reboot-cause] Save boot_id and device fields for DPU reboot cause - #405

Open

chartsai-nvidia wants to merge 5 commits into

sonic-net:masterfrom

chartsai-nvidia:chartsai/pmon-hld-update

chartsai-nvidia commented Jul 2, 2026 •

edited

Loading

Contributor

Why I did it

DPU reboot-cause entries written to CHASSIS_STATE_DB were missing the boot_id and
device fields, so consumers couldn't correlate a DPU reboot with its boot instance or
source device. NPU entries are unaffected.

Work item tracking

Microsoft ADO (number only): N/A

How I did it

Defined NPU_REBOOT_CAUSE_DB_FIELDS (cause, time, user, comment) and
DPU_REBOOT_CAUSE_DB_FIELDS (adds boot_id, device) in process-reboot-cause.
Replaced the hardcoded per-field db.set calls with a loop over the field set
selected by device type, so DPU rows now include boot_id and device.
Converted the showtech dump-path regex to a raw string to avoid invalid escape
sequence warnings without changing its matching behavior.

How to verify it

Run the unit tests: tests/process-reboot-cause_test.py now asserts that a DPU
reboot-cause file results in boot_id and device being written to
CHASSIS_STATE_DB.

Which release branch to backport (provide reason below if selected)

Description for the changelog

Save boot_id and device fields for DPU reboot-cause entries

mssonicbld commented Jul 2, 2026

/azp run

azure-pipelines Bot commented Jul 2, 2026

Azure Pipelines successfully started running 1 pipeline(s).

chartsai-nvidia mentioned this pull request

[PMON HLD] update get_reboot_cause mechanism and add get_midplane_dow… sonic-net/SONiC#2385

Merged

mssonicbld commented Jul 4, 2026

Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks!

_{---Powered by SONiC BuildBot}

dgsudharsan added the Request for 202605 Branch label

dgsudharsan approved these changes

View reviewed changes

mssonicbld commented Jul 8, 2026

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

_{---Powered by SONiC BuildBot}

12 similar comments

mssonicbld commented Jul 9, 2026

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

_{---Powered by SONiC BuildBot}

mssonicbld commented Jul 10, 2026

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

_{---Powered by SONiC BuildBot}

mssonicbld commented Jul 11, 2026

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

_{---Powered by SONiC BuildBot}

mssonicbld commented Jul 12, 2026

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

_{---Powered by SONiC BuildBot}

mssonicbld commented Jul 13, 2026

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

_{---Powered by SONiC BuildBot}

mssonicbld commented Jul 14, 2026

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

_{---Powered by SONiC BuildBot}

mssonicbld commented Jul 15, 2026

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

_{---Powered by SONiC BuildBot}

mssonicbld commented Jul 16, 2026

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

_{---Powered by SONiC BuildBot}

mssonicbld commented Jul 17, 2026

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

_{---Powered by SONiC BuildBot}

mssonicbld commented Jul 18, 2026

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

_{---Powered by SONiC BuildBot}

mssonicbld commented Jul 19, 2026

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

_{---Powered by SONiC BuildBot}

mssonicbld commented Jul 20, 2026

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

_{---Powered by SONiC BuildBot}

mssonicbld commented Jul 21, 2026

This PR has backport request label(s) for branch(es): 202605, but is missing required test information. Please make sure you tick the tested branch(es) in the Tested branch section and provide test evidence (e.g., 202605: <test result>) in the Test result section as well in your PR description.

_{---Powered by SONiC BuildBot}

mssonicbld commented Jul 21, 2026

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

_{---Powered by SONiC BuildBot}

1 similar comment

mssonicbld commented Jul 21, 2026

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

_{---Powered by SONiC BuildBot}

dgsudharsan removed the Request for 202605 Branch label

mssonicbld commented Jul 21, 2026

Hi @sonic-net/sonic-host-services-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

_{---Powered by SONiC BuildBot}

vvolam reviewed

View reviewed changes

vvolam left a comment

Contributor

Thanks for the cleanup — the loop-over-field-set refactor is clear and backward-compatible (NPU rows keep exactly cause/time/user/comment). One correctness gap inline regarding the device field, plus an optional nit below.

Nit (optional): to keep the two tuples from drifting, consider deriving one from the other:

NPU_REBOOT_CAUSE_DB_FIELDS = ("cause", "time", "user", "comment")
DPU_REBOOT_CAUSE_DB_FIELDS = NPU_REBOOT_CAUSE_DB_FIELDS + ("boot_id", "device")

scripts/process-reboot-cause Outdated

chartsai-nvidia added 2 commits

July 24, 2026 19:57


          add host recover json

7fc7aa1

Signed-off-by: Charles Tsai <chartsai@nvidia.com>


          fix tests

160ba86

Signed-off-by: Charles Tsai <chartsai@nvidia.com>

chartsai-nvidia force-pushed the chartsai/pmon-hld-update branch from 187331d to 160ba86 Compare

July 24, 2026 18:28

mssonicbld commented Jul 24, 2026

/azp run

azure-pipelines Bot commented Jul 24, 2026

Azure Pipelines: Successfully started running 1 pipeline(s).

gpunathilell approved these changes

View reviewed changes

dgsudharsan approved these changes

View reviewed changes


          revert unnecessary changes

3df9296

Signed-off-by: Charles Tsai <chartsai@nvidia.com>

mssonicbld commented Aug 24, 2026

/azp run

azure-pipelines Bot commented Aug 24, 2026

Azure Pipelines: Successfully started running 1 pipeline(s).

dgsudharsan requested a review from vvolam

August 28, 2026 16:01

gpunathilell approved these changes

View reviewed changes

vvolam commented Aug 31, 2026 •

edited

Loading

Contributor

The updated test_read_reboot_cause_files_and_save_to_db nicely confirms DPU rows now include boot_id/device, but nothing locks in the "NPU entries are unaffected" contract from the PR description. Since the field selection now hinges on device == 'npu', a future edit to NPU_REBOOT_CAUSE_DB_FIELDS could silently start writing DPU-only fields into STATE_DB without any test failing.

Consider adding a negative assertion in an NPU-focused test (where read_reboot_cause_files_and_save_to_db('npu') is invoked) so the boundary is enforced:

# NPU path must NOT write DPU-only fields
written_fields = {call.args[2] for call in mock_db.set.call_args_list}
assert "boot_id" not in written_fields
assert "device" not in written_fields

Purely additive — nothing here blocks merge.


          test: verify NPU reboot cause field boundary

68f118a

Signed-off-by: Charles Tsai <chartsai@nvidia.com>

vvolam approved these changes

View reviewed changes

vvolam left a comment

Contributor

LGTM, Thanks!

vvolam commented Sep 10, 2026

Contributor

/azpw run

mssonicbld commented Sep 10, 2026

⚠️ Notice: /azpw run only runs failed jobs now. If you want to trigger a whole pipline run, please rebase your branch or close and reopen the PR.
💡 Tip: You can also use /azpw retry to retry failed jobs directly.

Retrying failed(or canceled) jobs...

mssonicbld commented Sep 10, 2026

No Azure DevOps builds found for #405.

vvolam commented Sep 10, 2026

Contributor

/azpw retry

mssonicbld commented Sep 10, 2026

Retrying failed(or canceled) jobs...

mssonicbld commented Sep 10, 2026

No Azure DevOps builds found for #405.


          Merge branch 'sonic-net:master' into chartsai/pmon-hld-update

mssonicbld commented Sep 10, 2026

/azp run

azure-pipelines Bot commented Sep 10, 2026

Azure Pipelines: Successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet