Sanitize LLDP text and tolerate malformed port IDs - #86
Draft
ashutosh-agrawal wants to merge 1 commit into
Draft
ashutosh-agrawal wants to merge 1 commit into
ashutosh-agrawal wants to merge 1 commit into
Conversation
Signed-off-by: Ashutosh Agrawal <ashu@cisco.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden LLDP synchronization against malformed remote text and port identifiers. Parse otherwise-valid lldpctl JSON containing raw control characters, strip C0/C1 controls recursively from keys and values before they reach Redis or logs, and keep unknown or malformed port-ID shapes from aborting the entire update.
Motivation
A malformed TLV should not disable LLDP synchronization for unrelated interfaces. The existing parser can also raise on an unknown or non-object port ID before its exception handler runs.
Changes
Testing
The Azure sonic-dbsyncd pipeline passed at PR head
2b0160df. Its Python 3 job runspython3 setup.py testand publishes test results and coverage. A separate local attempt to runtests/test_lldpSyncDaemon.pystopped during collection becausemockrediswas unavailable; no local pass is claimed.