Skip to content

Reference section updates updates#1460

Open
LadyBluenotes wants to merge 94 commits intomainfrom
ref-updates
Open

Reference section updates updates#1460
LadyBluenotes wants to merge 94 commits intomainfrom
ref-updates

Conversation

@LadyBluenotes
Copy link
Copy Markdown
Member

No description provided.

…eaction, createSelector, indexArray, and mapArray
<div>
<header>{resolved()}</header>
<div>{resolved()}</div>
</div>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the previous example was better as to not encourage using the resolved children more than once.

If it were text children, then that example would have been ok,
https://playground.solidjs.com/anonymous/3b9366fa-717d-4c0c-8834-d2a69a455361

but if the children happen to be warpped in a div, then that div will only exist in 1 place at a time
https://playground.solidjs.com/anonymous/ca5d31b9-69e6-4609-b8cc-6545834644c0

the children helper wraps the function in a memo, that caches the value, so each time its called, it returns the same thing (as in, it wont create two divs)

return (
<ul>
{items.map((child) => (
{resolved.toArray().map((child) => (
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants