Open
Conversation
… onMount, runWithOwner, and untrack
…eaction, createSelector, indexArray, and mapArray
titoBouzout
reviewed
Apr 6, 2026
| <div> | ||
| <header>{resolved()}</header> | ||
| <div>{resolved()}</div> | ||
| </div> |
Collaborator
There was a problem hiding this comment.
Think the previous example was better as to not encourage using the resolved children more than once.
If it were text children, then that example would have been ok,
https://playground.solidjs.com/anonymous/3b9366fa-717d-4c0c-8834-d2a69a455361
but if the children happen to be warpped in a div, then that div will only exist in 1 place at a time
https://playground.solidjs.com/anonymous/ca5d31b9-69e6-4609-b8cc-6545834644c0
the children helper wraps the function in a memo, that caches the value, so each time its called, it returns the same thing (as in, it wont create two divs)
| return ( | ||
| <ul> | ||
| {items.map((child) => ( | ||
| {resolved.toArray().map((child) => ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.