Skip to content

fix(transfer-tokens): native transfer wrongly requires the recipient to co-sign #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NikkiAung wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −4
Open

fix(transfer-tokens): native transfer wrongly requires the recipient to co-sign #695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tokens/transfer-tokens/native/program/src/instructions/transfer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,11 @@ pub fn transfer_tokens(accounts: &[AccountInfo], args: TransferTokensArgs) -> Pr
from_associated_token_account.key,
to_associated_token_account.key,
owner.key,
&[owner.key, recipient.key],
// Empty: `owner` is a plain wallet authority, not a multisig account.
// A non-empty list here marks `owner` as non-signer and instead
// requires each listed pubkey to co-sign as a multisig member — which
// wrongly forced the recipient to sign just to receive tokens.
&[],
args.quantity,
)?,
&[
Expand Down
2 changes: 1 addition & 1 deletion tokens/transfer-tokens/native/tests/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ describe('Transferring Tokens', () => {
await findAssociatedTokenAddress(mint, payer.address),
await findAssociatedTokenAddress(mint, recipientWallet.address),
payer,
recipientWallet,
recipientWallet.address,
payer,
programId,
quantity,
Expand Down
6 changes: 4 additions & 2 deletions tokens/transfer-tokens/native/ts/instructions/transfer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export function createTransferTokensInstruction(
fromAssociatedTokenAccount: Address,
toAssociatedTokenAccount: Address,
owner: TransactionSigner,
recipient: TransactionSigner,
recipient: Address,
payer: TransactionSigner,
programId: Address,
quantity: bigint,
Expand All @@ -33,7 +33,9 @@ export function createTransferTokensInstruction(
{ address: fromAssociatedTokenAccount, role: AccountRole.WRITABLE },
{ address: toAssociatedTokenAccount, role: AccountRole.WRITABLE },
{ address: owner.address, role: AccountRole.WRITABLE_SIGNER, signer: owner },
{ address: recipient.address, role: AccountRole.WRITABLE_SIGNER, signer: recipient },
// Recipient just needs to be named, not to sign — receiving tokens
// must never require the recipient's approval.
{ address: recipient, role: AccountRole.READONLY },
{ address: payer.address, role: AccountRole.WRITABLE_SIGNER, signer: payer },
{ address: SYSTEM_PROGRAM_ADDRESS, role: AccountRole.READONLY },
{ address: TOKEN_PROGRAM_ADDRESS, role: AccountRole.READONLY },
Expand Down
Loading