Repository navigation
chore: remove ffmpeg dependencies from normal build - #1336
Merged
Merged
Conversation
WPT non-regression comparisonPASS — no regressions · 0 improved section(s) · overall 3427 → 3427 (0) Unchanged sections (28)
Baseline: Workflow run · this comment is updated on every push. |
closetcaiman
requested changes
Oct 7, 2026
Comment on lines
+50
to
+53
|
|
||
| :::warning Migrating from 0.x | ||
| Before 1.0.0 FFmpeg was linked by default and turned off with `disableFFmpeg` (Expo), `ENV['DISABLE_AUDIOAPI_FFMPEG'] = '1'` (iOS) or `disableAudioapiFFmpeg=true` (Android). Those flags are now ignored and only print a warning during `pod install` / Gradle configuration / `expo prebuild`. Apps that stream remote audio must opt in with the flags above; apps that already disabled FFmpeg need no change beyond removing the stale flag. | ||
| ::: |
Member
There was a problem hiding this comment.
I think that ad-hoc callouts are fine, but It would be awesome to have a migration guide section in the docs with all breaking changes. I don't know if it should be in this PR, but I'd create a section soon so that all upcoming PRs can just update the guide if they make a breaking change.
Member
Author
There was a problem hiding this comment.
yup, thought of that and it will be made
closetcaiman
requested changes
Oct 8, 2026
maciejmakowski2003
requested changes
Oct 8, 2026
closetcaiman
requested changes
Oct 8, 2026
closetcaiman
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes
Checklist