feat: add BUILD_TEMPLATE BDD opcode - #1335
Open
stobrien89 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What behavior changes?
Simple string templates now compile to a fused
BUILD_TEMPLATEinstruction instead of multiple load/property instructions followed byRESOLVE_TEMPLATE.Supported segments include literals, registers, and direct register properties. Complex expressions retain the existing fallback. Endpoint resolution results remain unchanged.
Generated bytecode now uses version 2, while version 1 bytecode remains readable.
Why is this change needed?
Template resolution currently requires an interpreter dispatch for each segment plus a final dispatch to concatenate them.
BUILD_TEMPLATEencodes eligible segments inline and resolves them in one dispatch, reducing interpreter and stack overhead while preserving existing allocation behavior.How was this validated?
TemplateResolutionBenchmark../gradlew :rulesengine:checkpasses with all 257 tests.What should reviewers focus on?
BytecodeCompiler: template eligibility and inline encoding.BytecodeEvaluator: fused template evaluation.BytecodeWalker: variable-length instruction validation.BytecodeDisassembler: symbolic template output.OpcodesandTemplateSegmentType: opcode and package-private segment tags.Bytecode: rolling version change from 1 to 2.TemplateResolutionBenchmark: comparison withRESOLVE_TEMPLATE.Additional Links
BUILD_TEMPLATEimplementation in smithy-php.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.