Fix XML isNull() misclassifying structure list members as null - #1330
Merged
Conversation
RanVaknin
approved these changes
Aug 20, 2026
yefrig
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What behavior changes?
The XML deserializer misjudged the nullability of a list element whose value is a structure when the XML was compact (no whitespace between the element and its firstchild).
For example, the following raises
SerializationException("Null value found in dense list"): the<member>element has no direct text all its data is in child elements.reader.getText().isEmpty()evaluates totrueinsideisNull()inXmlDeserializer, and the member is wrongly treated as null.This PR fixes it by additionally checking that the reader is at the element's END_ELEMENT, so only a genuinely empty element is treated as null.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.