Repository navigation
Use @DefaultValue when a primitive argument is explicitly null - #2787
Open
phillip-kruger wants to merge 1 commit into
Open
phillip-kruger wants to merge 1 commit into
phillip-kruger wants to merge 1 commit into
Conversation
jmartisk
approved these changes
Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A primitive argument with
@DefaultValueis nullable in the schema (the TCK requires@DefaultValuefields to be nullable), so a client can legally sendi: null.ArgumentHelperpassed thatnullon to the method, and reflection failed with anIllegalArgumentException.When a primitive argument with a default value gets an explicit
null,ArgumentHelpernow uses the schema default, coerced by graphql-java the same way as when the argument is left out. Wrapped arguments, non-primitives and the generated schema are unchanged.This covers query and mutation arguments only. Primitive fields in
@Inputtypes go through input deserialization and are not part of this change.PrimitiveDefaultValueTestchecks both the absent and the explicit-null case. The explicit-null case fails without the fix.Fixes #1565
Written with an AI coding agent. I approved the plan and I review this change.