Update to Net Framework 4.8, change to SDK style project, 3rd party libs updated#46
Open
flole1974 wants to merge 2 commits into
Open
Update to Net Framework 4.8, change to SDK style project, 3rd party libs updated#46flole1974 wants to merge 2 commits into
flole1974 wants to merge 2 commits into
Conversation
Owner
|
Thanks for the PR. Updating to .NET Framework 4.8 is good, as this is what most people have nowadays. However, .NET (Core) is not viable from my point of view, as I'd like to keep supporting Windows 7. That being said, have you tested this in Visual Studio? On my side the project doesn't load. Also, it's missing some source files to compile and string resources in other languages. Could you please look into that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a quick PR to modernize the solution a bit. I went as far as possible with newer versions of 3rd party dependencies, changed the csproj format to SDK style and upgraded to .NET 4.8.
I wanted to change it to .Net Core but this was not successful immediately. It would be a good thing though