Repository navigation
Build splatted attributes in a single output buffer - #983
Open
OskarEichler wants to merge 1 commit into
Open
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build splatted HTML attributes in one output buffer instead of allocating a result string for every attribute and then joining an array. Preserve attribute ordering, quoting and boolean handling.
Measurements
Ruby 4.0.6 with explicit YJIT; three alternating original/fixed pairs, five batches of 30,000 build_attrs calls per case (median over 15 batches):
The benchmark prepopulates a Builder with string keys and a mix of true/string values, warms it, then measures only repeated build_attrs calls using monotonic time and total_allocated_objects. Empty and single-attribute cases also improved. These are local microbenchmarks, not application throughput claims.
Verification
Compatibility / limitations
No intended output/API break or dependency change. Ordering and quoting options are retained. Performance varies by Ruby/workload; JRuby and the full supported-Ruby matrix have not been benchmarked.