Repository navigation
Copy embedded engine options before supplying defaults - #979
Open
OskarEichler wants to merge 1 commit into
Open
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Copy an embedded engine's option hash before adding the default encoding. Rendering should not mutate the caller's options; frozen configuration should work too.
Reproduction
With Kramdown available, this currently raises FrozenError while assigning default_encoding. With mutable options it silently adds a key to the caller's hash. The patch renders the same output and leaves both frozen and mutable input unchanged. Existing explicit encoding/default behavior is retained.
Verification
Compatibility / limitations
No API removal, dependency upgrade or intended breaking change. This is a shallow copy because only the top-level default is assigned. Kramdown/Asciidoctor and the existing suites were exercised; not every optional Tilt engine or Ruby implementation.