feat: Add --write-encoder-settings to tag streams with encoder settings - #320
Merged
Conversation
When enabled, the second-pass command writes an ENCODER_SETTINGS tag on each normalized audio stream, holding an ffmpeg-command-equivalent string with the codec, bitrate, sample rate and channels plus the normalization filter including the measured loudnorm values. It is added to the existing second-pass ffmpeg invocation, so no extra pass is performed. Has no effect together with --metadata-disable. CLI docs, shell completions and tests updated.
Owner
|
Thanks, this looks reasonable and is fairly complete. I'd just like to hear your motivation or use case for it? |
Contributor
Author
|
Hi! I have this little tool https://github.com/ppetr/audio-to-opus to convert audio to low bandwidth Opus files. While experimenting with various flag to optimize the codec for speech, I realized it'd be quite convenient to be able record the respective flags so that I could see what recording was done with what flags. And then I thought that a better place for this improvement would be ffmpeg_normalize so that others could benefit from it too (and also it has all the necessary information already available for the 2nd pass, so no 3rd remux is needed). |
Owner
|
This is now published, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enabled, the second-pass command writes an
ENCODER_SETTINGStag on each normalized audio stream, holding an ffmpeg-command-equivalent string with the codec, bitrate, sample rate and channels plus the normalization filter including the measured loudnorm values. It is added to the existing second-passffmpeginvocation, so no extra pass is performed.Has no effect together with
--metadata-disable. CLI docs, shell completions and tests updated.