Fix AfterConfigMap task to handle missing annotations and labels - #2570
Conversation
…ng retry loop Signed-off-by: Renato Granzoto <rgranzot@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe deployment verification retry conditions now guard custom label and annotation lookups and validate both metadata-level and template-level labels and annotations. ChangesLabel and annotation verification
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The end-to-end deployment verification now retries when labels or annotations have not yet been reconciled instead of failing on missing metadata, while also validating template metadata. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
When the label key does not exist yet (because the controller has not reconciled),
Ansible raises an error "dict object has no attribute" instead of treating it as a retry condition.
This doesn't happens in all runs, mainly when we get any performance limitation/slowness in the cluster.
The idea is to improve the way we check if the keys are already available before checking its value.