Repository navigation
Conversation
hopinheimer
reviewed
Oct 9, 2026
| let get_beacon_state_proposer_lookahead = | ||
| states::get_beacon_state_proposer_lookahead(beacon_states_path.clone()); | ||
|
|
||
| // `GET /eth/v1/beacon/states/{state_id}/ptc` |
Member
There was a problem hiding this comment.
nit: we can just have this to maintaining continuity
Suggested change
| // `GET /eth/v1/beacon/states/{state_id}/ptc` | |
| // `GET /beacon/states/{state_id}/ptc` |
hopinheimer
reviewed
Oct 9, 2026
| } | ||
|
|
||
| self | ||
| } |
Member
There was a problem hiding this comment.
We can have more tests to enforce 400 responses. exercising pre-gloas behavior and PTC window.
Author
There was a problem hiding this comment.
Addressed 38fef29
Test has been written in /http_api/tests/fork_tests.rs
hopinheimer
reviewed
Oct 9, 2026
hopinheimer
left a comment
hopinheimer
left a comment
Member
There was a problem hiding this comment.
Overall looks pretty good. Rounding up the tests would be nice.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Addresses the following 2 points
Proposed Changes
get_beacon_states_ptcandget_beacon_states_ptc_ssztoBeaconNodeHttpClient.PtcDataandPtcQuerytypes.validatorsis aFixedVectorto match the SSZ encoding mentioned in the spec for SSZ support.get_beacon_state_ptchandler instates.rsand register its route