Skip to content

fix: Multiple edited message shows up as a new message on recipient devices - #14928

Open
Sahil-Mandal15 wants to merge 1 commit into
signalapp:mainfrom
Sahil-Mandal15:fix-multiple-messages-show-up-on-edit-#14906
Open

fix: Multiple edited message shows up as a new message on recipient devices#14928
Sahil-Mandal15 wants to merge 1 commit into
signalapp:mainfrom
Sahil-Mandal15:fix-multiple-messages-show-up-on-edit-#14906

Conversation

@Sahil-Mandal15

@Sahil-Mandal15 Sahil-Mandal15 commented Aug 11, 2026

Copy link
Copy Markdown

Fixes #14906

Contributor checklist

  • Device Realme 10 pro+, Android 16.0
  • Virtual device Google Pixel 8, Android 15.0
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

This PR fixes the issue #14906 which mentions that whenever we edit a message twice while the device is not connected to the internet, then after connecting to the internet, the final edited message creates a new message.

While debugging, I found out that when a message is edited, the app tried to search for the parent of that particular message and this particular helper function returned the most previous version/parent of the message and not the root message, which caused the new update request (after connection is restored) to be a fresh creation instead of edit (as this request was made using the most recent version which was not available in the server and hence it is treated as a new message).

The fix was simple, I just changed the logic to fetch the root parent instead of the most recent version of the second edited message.

@Sahil-Mandal15 Sahil-Mandal15 changed the title fix: Multiple edited message shows up as a new message on recipient d… fix: Multiple edited message shows up as a new message on recipient devices Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiply edited message shows up as a new message on recipient devices

1 participant