fix: Multiple edited message shows up as a new message on recipient devices - #14928
Open
Sahil-Mandal15 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14906
Contributor checklist
Fixes #1234syntaxThis PR fixes the issue #14906 which mentions that whenever we edit a message twice while the device is not connected to the internet, then after connecting to the internet, the final edited message creates a new message.
While debugging, I found out that when a message is edited, the app tried to search for the parent of that particular message and this particular helper function returned the most previous version/parent of the message and not the root message, which caused the new update request (after connection is restored) to be a fresh creation instead of edit (as this request was made using the most recent version which was not available in the server and hence it is treated as a new message).
The fix was simple, I just changed the logic to fetch the root parent instead of the most recent version of the second edited message.