Repository navigation
docs: drop api-audiences from GCP Workload Identity guide - #873
Merged
Merged
Conversation
sterlingkoch
approved these changes
Oct 22, 2026
Google Cloud checks the audience on the projected service account token, not the kube-apiserver api-audiences. The listed value was misleading: the GCP entry lacked the // prefix, sts.googleapis.com had no use, and overriding the flag replaced the cluster endpoint audience Talos sets by default. Remove api-audiences from both patch variants, correct the intro and the provider URL section, and note which audience Google Cloud checks. Fixes siderolabs#856
Iheanacho-ai
force-pushed
the
gcp-workload-fix
branch
from
October 22, 2026 14:36
a0f203c to
bf040cb
Compare
Contributor
✅ Preview approved@Iheanacho-ai approved a Mintlify preview for commit |
📋 Automated documentation review
|
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
Member
Author
|
/m |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
api-audiencesfrom the Talos patch in the GCP Workload Identity Federation guide and corrects the text that said Google Cloud needs it.Fixes #856
Why
Google Cloud checks the audience on the pod's projected service account token, not the kube-apiserver
api-audiences. The suggested value caused problems://prefix, so it matched nothing. Adding the prefix would make the API server accept tokens minted for GCP.sts.googleapis.comhad no use, and it made the API server accept tokens minted for that audience.extraArgsreplaces theapi-audiencesvalue Talos sets by default (the cluster endpoint), so the cluster's existing pod tokens were rejected until refreshed.Change
public/kubernetes-guides/advanced-guides/gcp-workload-identity.mdx:api-audiencesand its comment from both patch tabs (Talos v1.14+ and < v1.14).audienceon the projectedserviceAccountTokenvolume.Testing
talosctl validate --mode metal(talosctl v1.14.0) on control plane configs with each patch applied. The v1.14+ patch was tested against a v1.14 config and the < v1.14 patch against a v1.13 config. Both are valid.release-1.14,control_plane_final.go(howextraArgsmergesapi-audiences),v1alpha1_k8s_bridge.go(default audience is the cluster endpoint), andk8s/service_account.go.make docs.jsonall pass with no changes todocs.json.extraArgsoverride behavior came from the Talos source.