Repository navigation
Conversation
Owner
Author
|
First Actions run on this branch: dependencies installed, lint passed, and under Xvfb 23 of 24 suites passed, including
|
shubshub
force-pushed
the
cq60/phase-4-version
branch
from
September 4, 2026 11:17
778add8 to
ea0d604
Compare
…needed (#68) It was written in five: build.sh, cli.py, the .TH line of the man page, two filenames in the README, and the top of the changelog. build.sh now reads it out of cli.py and substitutes it into the man page the way it already substitutes packaging/control, the README names no version at all and points at the Releases page instead, and release.sh reads cli.py too. That leaves two: the program, and the changelog entry build.sh already refuses to build without. release.sh step 3 keeps only the changelog check -- the man page and README have nothing left to disagree with -- and step 6 gains one on the built .TH line, since that is generated now rather than written. Also removes the blank line left in cli.load_input's docstring where the ponytail paragraph was. Closes 4. Phase 4 of #60. Co-authored-by: Shubshub <>
One job on ubuntu-24.04: ruff over src and tests, the 24 suites under xvfb, then ./build.sh to prove the package still assembles. Three of the apt packages are there for GSettings, because the suites look up real schemas rather than stubbing them: gnome-settings-daemon-common owns org.gnome.settings-daemon.plugins.media-keys and gnome-shell-common owns org.gnome.shell.keybindings, both of which the hotkey suite reads, and gsettings-desktop-schemas owns org.gnome.desktop.sound, which the sound suite reads. xvfb is there because every drawing test wants a display, even though none of them ever maps a window. No actions/setup-python: gi belongs to the system python3 that python3-gi installs into, and a second interpreter cannot see it. Closes 5. Phase 5 of #60.
The first run on GitHub Actions passed the lint and 23 of the 24 suites under Xvfb -- the hotkey, notification and schema lookups all held up -- and failed only test_sound.py, at "a player was chosen": sound.player_command found none of canberra-gtk-play, paplay, pw-play or aplay on the runner. The package recommends alsa-utils, so the runner gets it too, rather than the suite learning to look the other way. Phase 5 of #60, follow-up.
shubshub
force-pushed
the
cq60/phase-5-ci
branch
from
September 4, 2026 11:18
a472269 to
2319fe4
Compare
Owner
Author
|
Closed by GitHub when its base branch went away. Superseded by #69, same commit rebased onto main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 5 of 5 for #60. Stacked on #64; merge that first.
What
.github/workflows/ci.yml: one job onubuntu-24.04, on push and pull request,permissions: contents: read. Steps: checkout;apt-get installof the GTK/GI runtime plusxvfb,desktop-file-utilsand three schema packages;pipx run --spec ruff==0.16.6 ruff check src tests;xvfb-run -a python3 tests/run.py;./build.sh.Why the schema packages: the suites read real GSettings schemas rather than stubbing them.
gnome-settings-daemon-commonownsorg.gnome.settings-daemon.plugins.media-keysandgnome-shell-commonownsorg.gnome.shell.keybindings(both looked up bytest_hotkey.py, which runs underGSETTINGS_BACKEND=memory);gsettings-desktop-schemasownsorg.gnome.desktop.sound(test_sound.py). Confirmed withdpkg -Son a noble desktop.Deliberately no
actions/setup-python: the suites importgi, which belongs to the systempython3thatpython3-giinstalls into.Closes item 5 of #60. Closes #60.
Verification
Xephyr) with no window manager and no session daemons, and then again withDBUS_SESSION_BUS_ADDRESS,XDG_*andWAYLAND_DISPLAYunset: 24 suites, 0 failures both times. No suite needed a skip, and none was added.Departures from the issue text
pipx run --spec ruff==0.16.6rather thanpip install ruff:pip install --useron the noble runner hits PEP 668. Pinned so an unrelated PR cannot go red because a new ruff release added a rule. Bump this pin together with the local ruff.permissions: contents: readadded; the default token grant is wider than a lint-and-build job needs.