Skip to content

Fix/shopware5 links#2252

Open
Su (sushmangupta) wants to merge 4 commits intov6.6from
fix/shopware5-links
Open

Fix/shopware5 links#2252
Su (sushmangupta) wants to merge 4 commits intov6.6from
fix/shopware5-links

Conversation

@sushmangupta
Copy link
Copy Markdown
Contributor

Summary

Related links

Checklist

  • I reviewed affected links, code samples, and cross-references, including PageRef references where relevant.
  • I added or updated redirects in .gitbook.yaml if pages were moved, renamed, or deleted.
  • I updated .wordlist.txt (and sorted it) if spellcheck flags new legitimate terms.
  • Any required dependent changes in downstream modules have already been merged and published.
  • This pull request is ready for review.

Notes

Point developers.shopware.com links for B2B Suite, Composer plugin
installation, and plugin guidelines redirects to the mirrored docs at
https://devdocs.safefive.de/ with equivalent paths.
Copilot AI review requested due to automatic review settings April 22, 2026 12:05
@sushmangupta Su (sushmangupta) marked this pull request as draft April 22, 2026 12:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates documentation references and examples around Shopware 5 links and guide snippet inclusion, aligning the docs with the new target locations and updated configuration guidance.

Changes:

  • Replaced Shopware 5-related external links to point to devdocs.safefive.de and updated a .gitbook.yaml redirect.
  • Converted several snippet includes from the @/docs/... alias form to relative ../../.. paths.
  • Updated select guide examples (Order change listener API usage, Docker/OrbStack env vars, and Varnish XKey configuration guidance).

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
products/paas/shopware/project_setup.md Updates external Shopware composer/plugins documentation link.
products/extensions/b2b-suite/index.md Updates Shopware 5 B2B Suite documentation link.
guides/plugins/plugins/plugin-fundamentals/add-scheduled-task.md Switches snippet include to a relative path.
guides/plugins/plugins/checkout/order/listen-to-order-changes.md Updates the order-change example to use a newer command API and adds version note.
guides/plugins/apps/starter/product-translator.md Switches snippet include to a relative path.
guides/plugins/apps/app-sdks/symfony-bundle/index.md Switches snippet include to a relative path.
guides/installation/setups/docker.md Adds HTTPS-related environment variables to the OrbStack routing example.
guides/hosting/infrastructure/scheduled-task.md Switches snippet include to a relative path.
guides/hosting/infrastructure/reverse-http-cache.md Updates Varnish/XKey config guidance and adds cache-tagging settings.
.gitbook.yaml Updates redirect target for plugin-guidelines.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread products/extensions/b2b-suite/index.md Outdated
Comment on lines +99 to +100
// $command->getDefinition()->getEntityName() before Shopware 6.6.3.0
if ($command->getEntityName() !== OrderDefinition::ENTITY_NAME) {
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment about pre-6.6.3.0 contradicts the code sample: it says to use $command->getDefinition()->getEntityName() for older versions, but the snippet always calls $command->getEntityName() with no fallback. Either update the comment to state the minimum supported Shopware version for this guide/sample, or adjust the snippet to handle both APIs so it works as described.

Suggested change
// $command->getDefinition()->getEntityName() before Shopware 6.6.3.0
if ($command->getEntityName() !== OrderDefinition::ENTITY_NAME) {
$entityName = method_exists($command, 'getEntityName')
? $command->getEntityName()
: $command->getDefinition()->getEntityName();
if ($entityName !== OrderDefinition::ENTITY_NAME) {

Copilot uses AI. Check for mistakes.
Comment on lines +153 to +154
HTTPS: on
SERVER_PORT: 443
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In YAML examples, unquoted on and 443 can be parsed as boolean/integer depending on the YAML parser. Since Docker Compose environment values are strings, quote these values (e.g., "on", "443") to avoid unexpected coercion.

Suggested change
HTTPS: on
SERVER_PORT: 443
HTTPS: "on"
SERVER_PORT: "443"

Copilot uses AI. Check for mistakes.
Comment thread guides/hosting/infrastructure/reverse-http-cache.md Outdated
Su (sushmangupta) and others added 2 commits April 22, 2026 16:20
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sushmangupta Su (sushmangupta) changed the base branch from main to v6.6 April 22, 2026 15:38
@sushmangupta Su (sushmangupta) marked this pull request as ready for review April 22, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants