Tests: Add system tests for groupadd in test_groupadd.py#1655
Merged
Conversation
ikerexxe
reviewed
Jun 24, 2026
asakure
force-pushed
the
system_tests_groupadd
branch
from
8ba884c to
9cafdaf
Compare
ikerexxe
reviewed
Jun 25, 2026
ikerexxe
left a comment
ikerexxe
left a comment
Collaborator
There was a problem hiding this comment.
This has been improved quite a bit. There are still some minor things to improve, but I think we are on the right track
ikerexxe
reviewed
Jun 25, 2026
Collaborator
|
Please also check CI failures |
asakure
force-pushed
the
system_tests_groupadd
branch
2 times, most recently
from
2680fa4 to
4010eba
Compare
ikerexxe
reviewed
Jun 29, 2026
ikerexxe
left a comment
ikerexxe
left a comment
Collaborator
There was a problem hiding this comment.
In addition to the inline comments, you should run the linters:
flake8 .
pycodestyle .
isort --check-only .
black --check --diff .
mypy --install-types --non-interactive tests
They will raise a set of improvements that will make your tests run without problems (i.e. missing imports)
This is Python transformation of the test located in `tests/grouptools/groupadd/05_groupadd_set_GID/groupadd.test` which checks that `groupadd` can create group with sepcified GID using -g flag Signed-off-by: Akshay Sakure <asakure@redhat.com>
asakure
force-pushed
the
system_tests_groupadd
branch
2 times, most recently
from
b175b1f to
4b71f89
Compare
Contributor
Author
|
Hi @ikerexxe I have made suggested changes & ran the linters as well to confirm if there is any improvement scope, let me know if looks better now. |
ikerexxe
reviewed
Jul 1, 2026
ikerexxe
left a comment
ikerexxe
left a comment
Collaborator
There was a problem hiding this comment.
Almost there, just two minor things to improve and we are done
This is Python transformation of the test located in 'tests/grouptools/groupadd/04_groupadd_set_password/groupadd.test' which checks that 'groupadd' can create group with password using -p flag Signed-off-by: Akshay Sakure <asakure@redhat.com>
asakure
force-pushed
the
system_tests_groupadd
branch
2 times, most recently
from
d9dc7fc to
125cdf9
Compare
Collaborator
|
One last thing to get CI green and merge this PR: |
asakure
force-pushed
the
system_tests_groupadd
branch
from
125cdf9 to
2845d9d
Compare
This is Python transformation of the test located in 'tests/grouptools/groupadd/06_groupadd_-f_add_existing_group/groupadd.test' which checks that 'groupadd' completes successfully while force-creating an existing group using -f flag Signed-off-by: Akshay Sakure <asakure@redhat.com>
asakure
force-pushed
the
system_tests_groupadd
branch
from
2845d9d to
c2a9d70
Compare
ikerexxe
approved these changes
Jul 1, 2026
ikerexxe
left a comment
ikerexxe
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
openSUSE infrastructure seems to be down and CI can't install the dependencies. I'm merging anyways since all other runners succeeded
Contributor
Author
I see, I was wondering why CI is still failing even after making the changes. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add system tests for groupadd in test_groupadd.py.