Skip to content

Standardize builder's methods return typehint #293

Open

Description

@Jean-Beru

Fix builder's methods typehint from self to static.

Originally posted by @marilenaRM in #290 (comment)

Activity

  1. added this to the v2.0 milestone on Sep 6, 2026
  2. Amoifr commented on Oct 5, 2026

    @Amoifr

    Hi @Jean-Beru, happy to take this one if nobody has started on it yet. One question first: as marilenaRM showed on #290, moving the traits from self to static breaks a third-party builder that overrides one of these methods with : self, so it looks like 2.0 material. Should it wait for a 2.x branch, or would you rather have it on 1.x with a note in UPGRADE.md?

  3. Jean-Beru commented on Oct 5, 2026

    @Jean-Beru
    ContributorAuthor

    IMO, we should wait for a 2.0 branch which can be created from 1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions