Skip to content

ci(PLT-766): cancel superseded PR runs for remaining workflows#3649

Merged
masih merged 1 commit into
mainfrom
amir/plt-766-ci-concurrency-block-for-other-workflows
Jun 26, 2026
Merged

ci(PLT-766): cancel superseded PR runs for remaining workflows#3649
masih merged 1 commit into
mainfrom
amir/plt-766-ci-concurrency-block-for-other-workflows

Conversation

@amir-deris

@amir-deris amir-deris commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

What

Adds a concurrency block to the six PR-triggered workflows that were still missing one, so pushing a new commit to a PR cancels the prior in-progress run:

  • docker_build.yml (Build docker image)
  • golangci.yml (golangci-lint)
  • eth_blocktests.yml (ETH Blocktests)
  • forge-test.yml (Forge test)
  • mock_balances_build.yml (Mock Balances Build Check)
  • buf-check.yml (Buf)

Each gets the same block already used by integration-test.yml and go-test.yml:

concurrency:
  group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event_name == 'push' && github.sha || github.ref }}
  cancel-in-progress: ${{ github.event_name == 'pull_request' }}

Why

PR #3639 (PLT-761) added cancel-on-supersede, but concurrency is per-workflow — it only fixed integration-test.yml. The workflows above had no concurrency block, so superseded runs kept executing to completion and starved the ubuntu-large runner queue.

Observed on PR #3648: after pushing a 3rd commit, the 2nd commit's runs were cancelled for workflows that had the block (Docker Integration Test, Go Test, sei-db, Cross-Arch, UCI) but kept running for those that didn't (Build docker image, golangci-lint, ETH Blocktests).

Behavior

  • Keyed on github.sha for push and github.ref otherwise, with cancel-in-progress enabled only for pull_request — so push and merge_group runs are never cancelled by concurrency, matching the existing pattern.
  • Skipped dapp_tests.yml (only workflow_dispatch, never runs on PRs) and the publish/release workflows (ecr.yml, docker_publish.yml, proto-registry.yml) where cancellation is not wanted.

Follow-up to PLT-761 / #3639. Resolves PLT-766.

@amir-deris amir-deris self-assigned this Jun 25, 2026
@amir-deris amir-deris changed the title Made other CI workflows cancellable ci(PLT-766): cancel superseded PR runs for remaining workflows Jun 25, 2026
@cursor

cursor Bot commented Jun 25, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
CI workflow-only changes with no application or deployment logic touched.

Overview
Adds GitHub Actions concurrency to six workflows (buf-check, docker_build, eth_blocktests, forge-test, golangci, mock_balances_build) so overlapping runs share a group keyed by workflow, event type, and ref (or SHA on push).

cancel-in-progress is enabled only for pull_request events, so new pushes on a PR cancel older in-flight runs for that workflow/ref. Push and merge_group runs are not auto-cancelled by this flag.

Reviewed by Cursor Bugbot for commit 022852d. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJun 25, 2026, 10:48 PM

@amir-deris amir-deris requested review from bdchatham and masih June 25, 2026 22:52
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.18%. Comparing base (c45e3a8) to head (022852d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3649      +/-   ##
==========================================
- Coverage   59.15%   58.18%   -0.97%     
==========================================
  Files        2261     2178      -83     
  Lines      186911   177314    -9597     
==========================================
- Hits       110559   103173    -7386     
+ Misses      66417    64995    -1422     
+ Partials     9935     9146     -789     
Flag Coverage Δ
sei-db 70.41% <ø> (ø)
sei-db-state-db ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 83 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih masih added this pull request to the merge queue Jun 26, 2026
Merged via the queue into main with commit 44cbb32 Jun 26, 2026
90 of 94 checks passed
@masih masih deleted the amir/plt-766-ci-concurrency-block-for-other-workflows branch June 26, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants