ci(PLT-766): cancel superseded PR runs for remaining workflows#3649
Conversation
PR SummaryLow Risk Overview
Reviewed by Cursor Bugbot for commit 022852d. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3649 +/- ##
==========================================
- Coverage 59.15% 58.18% -0.97%
==========================================
Files 2261 2178 -83
Lines 186911 177314 -9597
==========================================
- Hits 110559 103173 -7386
+ Misses 66417 64995 -1422
+ Partials 9935 9146 -789
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
What
Adds a
concurrencyblock to the six PR-triggered workflows that were still missing one, so pushing a new commit to a PR cancels the prior in-progress run:docker_build.yml(Build docker image)golangci.yml(golangci-lint)eth_blocktests.yml(ETH Blocktests)forge-test.yml(Forge test)mock_balances_build.yml(Mock Balances Build Check)buf-check.yml(Buf)Each gets the same block already used by
integration-test.ymlandgo-test.yml:Why
PR #3639 (PLT-761) added cancel-on-supersede, but
concurrencyis per-workflow — it only fixedintegration-test.yml. The workflows above had noconcurrencyblock, so superseded runs kept executing to completion and starved theubuntu-largerunner queue.Observed on PR #3648: after pushing a 3rd commit, the 2nd commit's runs were cancelled for workflows that had the block (Docker Integration Test, Go Test, sei-db, Cross-Arch, UCI) but kept running for those that didn't (Build docker image, golangci-lint, ETH Blocktests).
Behavior
github.shaforpushandgithub.refotherwise, withcancel-in-progressenabled only forpull_request— sopushandmerge_groupruns are never cancelled by concurrency, matching the existing pattern.dapp_tests.yml(onlyworkflow_dispatch, never runs on PRs) and the publish/release workflows (ecr.yml,docker_publish.yml,proto-registry.yml) where cancellation is not wanted.Follow-up to PLT-761 / #3639. Resolves PLT-766.