Preserve MCP OAuth manager credentials on reread errors#349
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the OAuth token refresh mechanism to support a generic keyring store, improving testability. It introduces a helper function for loading tokens during refresh and adds a unit test to verify credential retention on keyring reread errors. The review feedback suggests ensuring proper initialization of the AuthorizationManager in the test helper by calling initialize_from_store and simplifying redundant type paths.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…reread-errors # Conflicts: # codex-rs/rmcp-client/src/oauth.rs
Summary
dev/stevenlee/mcp-oauth-stack-6-auto-read-errors/ commit2b64cf47dbin downstream-shaped form.Validation
rustfmt --check codex-rs/rmcp-client/src/oauth.rsgit diff --checkcargo test -p codex-rmcp-client --lib oauth::tests::refresh_transaction_keeps_manager_credentials_on_keyring_reread_error -- --exactUpstream harvest note
dev/stevenlee/mcp-oauth-stack-6-auto-read-errorswith no open PR at the time of inspection; this PR lands the relevant downstream-compatible regression coverage and refresh reread seam.