Repository navigation
Conversation
ryybrr
reviewed
Oct 29, 2026
The TPIDRURO register is now unused. Remove corresponding machine ops and C machine op assumption. See also #1105 Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
corlewis
approved these changes
Oct 30, 2026
corlewis
left a comment
corlewis
left a comment
Member
There was a problem hiding this comment.
Just confirming, do we still want to list TPIDRURO in data Register in spec/haskell/src/SEL4/Machine/RegisterSet/ARM.lhs? I think that's the last appearance of it after this.
Member
Author
The register as such still exists, so we still want it in the register set. The kernel just doesn't read/write it explicitly any more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TPIDRURO register is now unused. Remove corresponding machine ops and C machine op assumption.
See also #1105
Not urgent and can wait until CI has settled down after the release.