Enable more ControlConnectionTests - #497
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe integration test bridge now passes Merge Risk: ⚪ Minimal · up to This PR enables additional control-connection integration tests and adjusts their supporting test configuration; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
The test assumed a logger message present in CPP Driver, which is different in Rust Driver. Adjusting the expected message's prefix fixed the test.
A `--scylla` flag was not passed to CCM when `add_node` operation was performed. This was an oversight from when the bridge was adapted to ScyllaDB.
The test assumed a logger message present in CPP Driver, which is different in Rust Driver. Adjusting the expected message's part fixed the test.
9917286 to
1b677c4
Compare
There was a problem hiding this comment.
Pull request overview
Enables the TopologyChange and FullOutage control-connection tests for Scylla.
Changes:
- Updates assertions to match current driver log messages.
- Marks dynamically added CCM nodes as Scylla nodes.
- Removes both tests from the Scylla exclusion filter.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Makefile |
Enables both tests for Scylla. |
tests/src/integration/ccm/bridge.cpp |
Adds Scylla nodes with --scylla. |
tests/src/integration/tests/test_control_connection.cpp |
Updates expected log criteria. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This PR enables some tests from
ControlConnectionTestssuite:FullOutageandTopologyChange.Pre-review checklist
[ ] I have provided docstrings for the public items that I want to introduce.[ ] I have adjusted the documentation in./docs/source/.[ ] I have implemented Rust unit tests for the features/changes introduced.Makefilein{SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER.[ ] I added appropriateFixes:annotations to PR description.