Skip to content

Enable more ControlConnectionTests - #497

Merged
wprzytula merged 3 commits into
scylladb:masterfrom
wprzytula:enable-more-cc-tests
Aug 21, 2026
Merged

Enable more ControlConnectionTests#497
wprzytula merged 3 commits into
scylladb:masterfrom
wprzytula:enable-more-cc-tests

Conversation

@wprzytula

@wprzytula wprzytula commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

This PR enables some tests from ControlConnectionTests suite: FullOutage and TopologyChange.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • PR description sums up the changes and reasons why they should be introduced.
  • [ ] I have provided docstrings for the public items that I want to introduce.
  • [ ] I have adjusted the documentation in ./docs/source/.
  • [ ] I have implemented Rust unit tests for the features/changes introduced.
  • I have enabled appropriate tests in Makefile in {SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER.
  • [ ] I added appropriate Fixes: annotations to PR description.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Pro Plus

Run ID: 62817752-d3a0-4d17-ac8c-a319918fba1a

📥 Commits

Reviewing files that changed from the base of the PR and between cd7841f and 1b677c4.

📒 Files selected for processing (3)
  • Makefile
  • tests/src/integration/ccm/bridge.cpp
  • tests/src/integration/tests/test_control_connection.cpp
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • scylladb/scylladb (auto-detected)
💤 Files with no reviewable changes (1)
  • Makefile

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The integration test bridge now passes --scylla when it creates nodes for Scylla clusters. The control-connection tests now match the current node-addition and node-reconnection log messages. Two topology and outage tests were removed from the default test filter.

Merge Risk: ⚪ Minimal · up to 1b677

This PR enables additional control-connection integration tests and adjusts their supporting test configuration; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: enabling additional ControlConnectionTests.
Description check ✅ Passed The description summarizes the enabled tests, explains the related updates, and completes the applicable checklist items.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@wprzytula wprzytula added the area/testing Related to unit/integration testing label Aug 20, 2026
@wprzytula wprzytula self-assigned this Aug 20, 2026
@wprzytula wprzytula modified the milestones: 1.x, 1.2 Aug 20, 2026
The test assumed a logger message present in CPP Driver, which is
different in Rust Driver. Adjusting the expected message's prefix fixed
the test.
A `--scylla` flag was not passed to CCM when `add_node` operation was
performed. This was an oversight from when the bridge was adapted to
ScyllaDB.
The test assumed a logger message present in CPP Driver, which is
different in Rust Driver. Adjusting the expected message's part fixed
the test.
@wprzytula
wprzytula force-pushed the enable-more-cc-tests branch from 9917286 to 1b677c4 Compare August 20, 2026 16:07
@wprzytula
wprzytula marked this pull request as ready for review August 20, 2026 16:08
@wprzytula
wprzytula requested review from Lorak-mmk and a balanced review from Copilot August 20, 2026 16:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables the TopologyChange and FullOutage control-connection tests for Scylla.

Changes:

  • Updates assertions to match current driver log messages.
  • Marks dynamically added CCM nodes as Scylla nodes.
  • Removes both tests from the Scylla exclusion filter.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
Makefile Enables both tests for Scylla.
tests/src/integration/ccm/bridge.cpp Adds Scylla nodes with --scylla.
tests/src/integration/tests/test_control_connection.cpp Updates expected log criteria.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@wprzytula
wprzytula merged commit 18fa15e into scylladb:master Aug 21, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/testing Related to unit/integration testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants