fix static asset paths to load from project root - #73
Conversation
Thank you for the pull request! 💙The Scribe-Server team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
First PR Commit Check
|
|
Hi @andrewtavis could you check this? The root cause is that the web images were tied to the I just made sure we don't depend on contributors' local config setup. This was why one configuration was working for one computer and not working on another. |
andrewtavis
left a comment
There was a problem hiding this comment.
Thanks so much for checking this, @DeleMike! So great that this is fixed so quickly 😊
Contributor checklist
./pre-commitexecutable as well asmake lintand have fixed all reported issuesDescription
Fixes the broken logo images caused by differing local configurations.
Root cause:
The web images were tied to the
fileSystemvariable (which dictates where data packs live). If a user'sfileSystemwasn't set to the exact project root, the image paths broke.I just made sure we don't depend on contributors' local config setup. This was why one configuration was working for one computer and not working on another.
Reference: #72 (comment)