add changelog v1.0.0 - #66
Conversation
Thank you for the pull request! 💙🩵The Scribe-Server team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
|
Hi @andrewtavis, @axif0: I have added an initial draft for the changelog. What do you think? |
|
praise: This is looking so amazing, @DeleMike! 🤩 I just sent along minor changes and the same changes to the workflows that I sent to #68. One note: The docs endpoint that's listed isn't working?
|
|
I will look into that and send a fix here. Thanks for noticing ✨ |
|
Thanks for checking it out, @DeleMike! Happy to merge this in once we figure it out 😊 |
|
Hi @andrewtavis, the issue is that https://scribe-server.toolforge.org/swagger/index.html works and https://scribe-server.toolforge.org/docs/index.html does not. And it is because - r.GET("/swagger/*any", ginSwagger.WrapHandler(swaggerFiles.Handler))
+ r.GET("/swagger/*any", ginSwagger.WrapHandler(swaggerFiles.NewHandler()))
- r.GET("/docs/*any", ginSwagger.WrapHandler(swaggerFiles.Handler))
+ r.GET("/docs/*any", ginSwagger.WrapHandler(swaggerFiles.NewHandler()))I really hope this works when it is pushed to Toolforge. Because on localhost, but were working with the former code. If it does not, then we should stick to https://scribe-server.toolforge.org/swagger/index.html while we find out what exactly the problem is. |
andrewtavis
left a comment
There was a problem hiding this comment.
praise: Thanks for this, @DeleMike! Let's give this a go for the docs endpoint :)
|
Hi @andrewtavis , the addition fixed the issue. The docs link now works. see link here: https://scribe-server.toolforge.org/docs/index.html |
|
Amazing, @DeleMike! Thanks for the solution and the heads up :) |
Contributor checklist
./pre-commitexecutable as well asmake lintand have fixed all reported issuesDescription
Added first draft for
CHANGELOG.md.Related issue