Skip to content

add changelog v1.0.0 - #66

Merged
andrewtavis merged 3 commits into
scribe-org:mainfrom
DeleMike:fix/changelog-v1
Jul 14, 2026
Merged

add changelog v1.0.0#66
andrewtavis merged 3 commits into
scribe-org:mainfrom
DeleMike:fix/changelog-v1

Conversation

@DeleMike

Copy link
Copy Markdown
Collaborator

Contributor checklist

  • This pull request is on a separate branch and not the main branch
  • I have ran the ./pre-commit executable as well as make lint and have fixed all reported issues

Description

Added first draft for CHANGELOG.md.

Related issue

@github-actions

Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-Server team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Data rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the continuous integration (CI) workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@DeleMike DeleMike changed the title add initial draft of changelog v1.0.0 add changelog v1.0.0 Jul 13, 2026
@DeleMike
DeleMike requested review from andrewtavis and axif0 July 13, 2026 14:27
@DeleMike DeleMike self-assigned this Jul 13, 2026
@DeleMike

Copy link
Copy Markdown
Collaborator Author

Hi @andrewtavis, @axif0: I have added an initial draft for the changelog. What do you think?

@andrewtavis

Copy link
Copy Markdown
Member

praise: This is looking so amazing, @DeleMike! 🤩 I just sent along minor changes and the same changes to the workflows that I sent to #68.

One note: The docs endpoint that's listed isn't working?

@DeleMike

Copy link
Copy Markdown
Collaborator Author

I will look into that and send a fix here. Thanks for noticing ✨

@andrewtavis

Copy link
Copy Markdown
Member

Thanks for checking it out, @DeleMike! Happy to merge this in once we figure it out 😊

@DeleMike

Copy link
Copy Markdown
Collaborator Author

Hi @andrewtavis, the issue is that https://scribe-server.toolforge.org/swagger/index.html works and https://scribe-server.toolforge.org/docs/index.html does not. And it is because /swagger and /docs were sharing the same swaggerFiles.Handler instance, and gin-swagger overwrites that handler's internal prefix based on whichever route hits it most recently. I changed to:

- r.GET("/swagger/*any", ginSwagger.WrapHandler(swaggerFiles.Handler))
+ r.GET("/swagger/*any", ginSwagger.WrapHandler(swaggerFiles.NewHandler()))
- r.GET("/docs/*any", ginSwagger.WrapHandler(swaggerFiles.Handler))
+ r.GET("/docs/*any", ginSwagger.WrapHandler(swaggerFiles.NewHandler()))

I really hope this works when it is pushed to Toolforge. Because on localhost, but were working with the former code.

If it does not, then we should stick to https://scribe-server.toolforge.org/swagger/index.html while we find out what exactly the problem is.

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thanks for this, @DeleMike! Let's give this a go for the docs endpoint :)

@andrewtavis
andrewtavis merged commit bf1e6b7 into scribe-org:main Jul 14, 2026
1 check passed
@DeleMike
DeleMike deleted the fix/changelog-v1 branch July 15, 2026 11:06
@DeleMike

Copy link
Copy Markdown
Collaborator Author

Hi @andrewtavis , the addition fixed the issue. The docs link now works.

see link here: https://scribe-server.toolforge.org/docs/index.html

@andrewtavis

Copy link
Copy Markdown
Member

Amazing, @DeleMike! Thanks for the solution and the heads up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write Scribe-Server changelog and release v1.0.0

2 participants