Skip to content

First draft: validate watch files#37

Closed
gaku-sei wants to merge 1 commit into
v2from
validate-watch
Closed

First draft: validate watch files#37
gaku-sei wants to merge 1 commit into
v2from
validate-watch

Conversation

@gaku-sei

@gaku-sei gaku-sei commented Aug 6, 2021

Copy link
Copy Markdown
Contributor

Closes #36

Revalidates project on file change. Notice that since notify (the library we use for watching/executing) doesn't support globs the user must provide the path twice (also, they could be different and in the future I think it would make sense to accept a list of -w or to have it in a config file (#35)).

Seems to work well and the dev experience even on large projects (~5000 files of ~650 lines each) is smooth.

Some things to improve:

  • Code (it's a bit rough and basically copied from the generate command)
  • Ownership is not good (we send arc here and there, clone them when not needed, watch path is not computed when it should etc...)
  • Not exit on file rename (except the file is the css file), just keep going
  • Better error handling

@gaku-sei gaku-sei added the WIP label Aug 6, 2021
@gaku-sei

Copy link
Copy Markdown
Contributor Author

Closed by #40

@gaku-sei gaku-sei closed this Aug 10, 2021
@gaku-sei gaku-sei deleted the validate-watch branch August 10, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Watch mode

1 participant