Require NXevent_data has some "event" datasets #69
Merged
Conversation
SimonHeybrock
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw this test failure:
https://scipp.github.io/nightly-dashboard/latest/nexusfiles-scipp_estia_load_raw_file_.html
The failing component seems to be a
NXevent_dataentry in the file that actually encodes a histogram monitor.The added validator checks that any
NXevent_datagroup has at least one ofevent_time_offsetorevent_iddatasets.This is strictly speaking not required by the Nexus standard, because both fields are optional, but I don't think there is a use case for having an event data group without
event_idorevent_time_offsetso I think it makes sense to be "opinionated" here.