chore: Add Claude Review workflow - #22
Conversation
Signed-off-by: Guillaume Carre <guillaume.carre@scality.com>
g-carre
changed the title
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
|
||
| | Area | What to check | | ||
| |------|---------------| | ||
| | Reconciler idempotency | Reconcile must be safe to run repeatedly; no assumptions about being called once. Derive desired state from spec, converge, and avoid side effects that don't tolerate retries. | |
There was a problem hiding this comment.
Review criteria here diverge from .claude/REVIEW.md. Missing: CRL correctness, key material handling, requeue scheduling, tests, manager manifests, docs. Extra: webhook validation, interface compliance, goroutine leaks. This will drift over time.
Replace the hardcoded table with an instruction to read the existing criteria file:
| | Reconciler idempotency | Reconcile must be safe to run repeatedly; no assumptions about being called once. Derive desired state from spec, converge, and avoid side effects that don't tolerate retries. | | |
| 3. **Read the review criteria** from `.claude/REVIEW.md`, then **analyze the changes** against them. |
| description: Review a PR on crl-operator (a Go Kubernetes operator managing Certificate Revocation Lists via cert-manager) | ||
| argument-hint: <pr-number-or-url> | ||
| disable-model-invocation: true | ||
| allowed-tools: Read, Bash(gh repo view *), Bash(gh pr view *), Bash(gh pr diff *), Bash(gh pr comment *), Bash(gh api *), Bash(git diff *), Bash(git log *), Bash(git show *) |
There was a problem hiding this comment.
Bash(gh api *) allows any GitHub API call (any method, any endpoint) — not just the review-comment POST the skill needs. Consider scoping to the specific patterns required, or removing it and relying on a helper script for posting.
Also, Bash(gh pr comment *) enables posting top-level PR comments, which adds noise — the hub-managed skill uses check runs instead for the summary.
2 participants
Add Claude revivew to the project