[aarmastah]

Description

Steam Networking / SDR IP addresses always use 169.254.x.x, which causes problems for a plugin like this. When every player uses the same IP range, SourceSleuth becomes ineffective and there's no point in storing these IPs in the first place, so I disable the IP check on this internal address range and disable storing it as well. This prevents existing IPs causing trouble as well as needlessly storing new ones.

Motivation and Context

This change fixes innocent players being banned from SDR-enabled servers that use SourceBans++ and do not know to turn off SourceSleuth (don't ask me how I know -- (the answer is experience)).

How Has This Been Tested?

I tested this by compiling my plugin changes, running a dedicated TF2 server on Windows with -enablefakeip, connecting to said server in TF2 via SDR, banning my alt account, and seeing it populate on my SB++ instance with no IP listed, exactly as expected.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.

[rumblefrog]

Can you link official docs on this?

Also can be moved to an include since it's shared across plugins

[aarmastah]

I can't find any official documentation that specifically states an IP assignment of "169.254.x.x" when using SDR in Source SDK 2013 games, but I did find direct reference to it in the source code:

https://github.com/ValveSoftware/source-sdk-2013/blob/be57e3d01ac7d7aa6a2cacbfef187c0b46616db0/src/public/steam/isteamnetworkingsockets.h#L812-L820

[rumblefrog]

Got it, can you add this to the stock's comments.

[aarmastah]

Technically, the comment also says "this is subject to change! Do not make assumptions about these addresses. or your code might break in the future." It points out that you could use "ISteamNetworkingUtils::IsFakeIP to determine if an IP address is a "fake" one used by this system," but I wouldn't have direct access to this without writing a new extension that SB++ would now have to rely on.

Given it's been several years without any change in the IP format, I highly doubt it's going to change any time soon. I think the current method is okay. Do you have any opinions?

[aarmastah]

I've added the comment from the Source 2013 SDK as requested. Please note my comment from earlier:

Technically, the comment also says "this is subject to change! Do not make assumptions about these addresses. or your code might break in the future." It points out that you could use "ISteamNetworkingUtils::IsFakeIP to determine if an IP address is a "fake" one used by this system," but I wouldn't have direct access to this without writing a new extension that SB++ would now have to rely on.

Given it's been several years without any change in the IP format, I highly doubt it's going to change any time soon. I think the current method is okay. Do you have any opinions?

Adding to this: the IP format has remained the same since TF2's SDR implementation back in ~2021.

[rumblefrog]

couple things outside the diff:

• sbpp_checker.sp still uses raw GetClientIP (L191 count query, L284 sm_listbans), so SDR players still get matched against every 169.254 IP ban there
• existing 169.254.x.x values already in the DB (bans.ip, comms.adminIp, submissions, etc) stick around. probably want a cleanup migration to null those out
• since this changes plugin behavior self-hosters will see (sm_banip refusing SDR targets, sleuth skipping them), can you add a note to docs/src/content/docs/setup/plugin-setup.md

range check is fine by me btw, don't think it's worth pulling in an extension for IsFakeIP

---

Generated by Claude Code

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[aarmastah]

I have read the CLA Document and I hereby sign the CLA