Whirlwind of change ideas - #21

Draft

mhagger wants to merge 103 commits into

saml-dev:mainfrom

mhagger:whirlwind

Commits on May 2, 2024

NewAppFromConfig(): more flexible way to configure an `App`
mhagger
committed
087e530
`ctx` should always be a function's first argument
mhagger
committed
5f407ed
Remove some unused `ctx` arguments
mhagger
committed
f56fee7
Get rid of the `ctx` members in the service subtypes
mhagger
committed
17fa8bc
newService(): remove the `ctx` argument
mhagger
committed
3cb2d8d
Add a `ctx` argument to functions that set up a websocket connection
mhagger
committed
77effe9
App: remove the `ctx` member
mhagger
committed
a11cb4f
runSchedules(): simplify loop code
mhagger
committed
7071b55
runIntervals(): simplify loop code
mhagger
committed
680cf67
runIntervals(), runSchedules(): convert functions in to methods
mhagger
committed
d035b67
Interval, DailySchedule: extract `shouldRun()` methods
mhagger
committed
9190da4
Handle schedules and intervals using shared code
mhagger
committed
9261f61
Work on cleanup of goroutines
mhagger
committed
803e4ea
Make example compile
mhagger
committed
2459f0e
ListenWebsocket(): add comment, tighten signature
mhagger
committed
516b5af
Remove unnecessary abbreviation
mhagger
committed
311327f
WebsocketConn: type renamed from `WebsocketWriter`
mhagger
committed
feabb04
WebsocketConn.Close(): new method
mhagger
committed
5aab2a6
WebsocketConn.WriteMessage(): change receiver name
mhagger
committed
0a6c6f1
ListenWebsocket(): make a method of `WebsocketConn`
mhagger
committed
4a31f80
App.conn: remove member
mhagger
committed
8fc04de
WebsocketConn: change how type is constructed
mhagger
committed
b57a5c0
WebsocketConn.conn: make member private
mhagger
committed
6e24f42
websocket.Conn: rename type from `WebsocketConn`
mhagger
committed
ed26c0c
Remove some more abbreviations
mhagger
committed
a30ad12
websocket.Conn: add some methods
mhagger
committed
94ccdc4
websocket.Conn.Start(): rename method from `ListenWebsocket()`
mhagger
committed
f866c52
websocket.Conn: add some more methods
mhagger
committed
0fd02f8
websocket.Conn: introduce a way to subscribe to IDs
mhagger
committed
059e346
Subscribe to state changed listeners through the new mechanism
mhagger
committed
7bc5ce6
More work on event handling
mhagger
committed
309efa9
Subscribe to event listeners through the new mechanism
mhagger
committed
84b0755
Rename local `*App` variables to `app`
mhagger
committed
ef130ce
Split up overlong lines
mhagger
committed
ec5eece
Always get the next message ID from `Conn`
mhagger
committed
c7e894f
Get rid of the wacky generic `BuildService()` function
mhagger
committed
db5cf90
Change how message IDs are allocated and messages are sent
mhagger
committed
c781076
Make `serviceData`, where supported, non-optional
mhagger
committed
b396ae7
Use more conventional capitalizations (e.g., `Id` → `ID`)
mhagger
committed
f5b6f7a
Initialize `CallServiceRequest` objects while defining them
mhagger
committed
d349cd0
Remove `types` package
mhagger
committed
8e146c1
Change `serviceData` types from `map[string]any` to `any`
mhagger
committed
4485009
SetTemperatureRequest: distinguish between 0°C and "unset"
mhagger
committed
06927b2
ChanMsg: remove unused field `Success`
mhagger
committed
8a89b44
ChanMsg.Raw: change type to `json.RawMessage`
mhagger
committed
4a7d8fe
BaseResultMessage: type renamed from `BaseMessage`
mhagger
committed
be0e941
BaseMessage: new type, implementing the minimum fields for a message
mhagger
committed
1989fa5
websocket.Message: type renamed from `ChanMsg`
mhagger
committed
e88d4eb
Move the message types to a separate file
mhagger
committed
da3c113
authRequest: rename type from `AuthMessage`
mhagger
committed
9ca032d
MessageWriter: add an `Unsubscribe()` method
mhagger
committed
5e6aa5d
LockedConn: type renamed from `MessageWriter`
mhagger
committed
8b6fe94
Move subscription-related code to a separate file
mhagger
committed
4e4a39f
Subscription.Cancel(): remove method
mhagger
committed
897b49c
Inline some subscription-related functions in `lockedConn`
mhagger
committed
5a3fdba
Remove a race related to variable-capture
mhagger
committed
307fd01
App: add convenience methods for interacting with the service
mhagger
committed
26d94f6
Change a couple of services to use the new call mechanism
mhagger
committed
26bb7b7
Switch to the new way of calling services
mhagger
committed
f5833fc
Make the websocket package public
mhagger
committed
10c8d53
Target: allow device targets
mhagger
committed
f069988
Move the "application" code to package `app`
mhagger
committed
826704b
Move `Target` to the top level
mhagger
committed
2ffa0f9
Allow service methods to take any `Target` as argument
mhagger
committed
6fc5e5d
State(): add methods `Latitude()` and `Longitude()`
mhagger
committed
aa8e2ed
App.state: change type from `*StateImpl` to `State`
mhagger
committed
8af6443
App: make fields `Service` and `State` public
mhagger
committed
cdecbb7
Change how callbacks are invoked
mhagger
committed
7fff90d
App: extract methods to register single listeners
mhagger
committed
f3e163d

Commits on May 11, 2024

Include the raw data in `EntityState`
mhagger
committed
e3c0e86
Rename two `App` methods:
mhagger
committed
33091fe
app.go: reorder method definitions
mhagger
committed
7360b95
subscribeEventsRequest: rename from `SubEvent`
mhagger
committed
7b42441

Commits on May 12, 2024

Target.String(): new method
mhagger
committed
8d29eb2
Improve how raw messages are output
mhagger
committed
9f96127
Message: avoid inadvertently filling the `Raw` field from the JSON
mhagger
committed
fe7913f
Subscribe(): no need to wrap the incoming context
mhagger
committed
890f13e
Add a way to tell when the app is ready for use
mhagger
committed
7a3f730
Start the `websocket.Conn` earlier in the initialization sequence
mhagger
committed
0789d28
App.SubscribeEvents(): use `App.Subscribe()` in implementation
mhagger
committed
753f589
Conn.Start(): rename local variable
mhagger
committed
4fc05c1
Conn.Start(): not all messages will be result messages
mhagger
committed
965a857
websocket.ResultMessage: new type
mhagger
committed
f94d31b
app/calls.go: new file, extracted from `app.go`
mhagger
committed
2815fc9
Change the service calling convention
mhagger
committed
c61c702

Commits on May 17, 2024

Start adding code to handle websocket `state_changed` events
mhagger
committed
162e969

Commits on May 26, 2024

Move `RawMessage` definition to a separate file
mhagger
committed
cf22ace
Move `ResultMessage` definition to a separate file
mhagger
committed
e04a1b9
Move `CompressedStateChangedMessage` definition to a separate file
mhagger
committed
17f3dac
EventContext, BaseEvent, Event, EventMessage: new types
mhagger
committed
6d1b0a0
JWaveJSEventData: new type
mhagger
committed
3ae4160
Change event listeners to take `websocket.Event` as argument
mhagger
committed
0d35e28

Commits on Jun 2, 2024

`encoding/json` should be able to unmarshal the time string here
mhagger
committed
1712847
Rename `EntityState` to `Entity`
mhagger
committed
cd413cc
EntityState: new type
mhagger
committed
f278132
According to the Python, the context ID can be null
mhagger
committed
e818956
`encoding/json` should be able to unmarshal the time string here
mhagger
committed
49d8b8e
entity.go: new file, split out from `state_changed_message.go`
mhagger
committed
e027a8e
RawObject: new type
mhagger
committed
a472d81
Partly generify the `Entity` types
mhagger
committed
17c832a
ApplyChange(): function to apply changes to an arbitrary entity
mhagger
committed
200eb25
Use a specialized `Context` type in more places
mhagger
committed
87dd38d

Commits on Jun 15, 2024

Timestamps can be either strings or floats
mhagger
committed
22584dd