Fix editable installs for troubleshooting#69078
Merged
Merged
Conversation
twangboy
force-pushed
the
fix/setup_editable/3006.x
branch
from
eaa7f80 to
169d7ae
Compare
dwoz
force-pushed
the
fix/setup_editable/3006.x
branch
from
003cab9 to
a0abda8
Compare
In the salt_build_backend fixture, set SETUPTOOLS_USE_DISTUTILS=stdlib only while importing tools/pkg/salt_build_backend and drop cached distutils modules first. This avoids setuptools _distutils_hack failing when the onedir interpreter bundles stdlib distutils before the shim completes. Env is restored when the fixture exits; other tests are unaffected except a possible distutils re-import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Something broke editable installs at some point. This fixes that
Fixes: #69101
Previous Behavior
Could not
pip install -e .saltNew Behavior
pip install -e .now creates an editable installMerge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes